Home → Problems →

"Mergin" stylesheets and javascript files causing problems

Galen King

27 Jan, 2011 09:24 PM via web

Admin Functions

• Edit
• Remove

Hey guys,

I thought it was a great optimisation to merge multiple .js and .css files however it's breaking a number of our sites.

The images on the front page of www.timberworksnz.com should cross-fade and gallery pages like this (http://timberworksnz.com/projects/post_and_beam/summer-house/tasman...) should have an image slider. They don't work.

We realised something is more widespread when we noticed the lightbox doesn't work on http://furneaux.co.nz/gallery/ either.

So, if I separate the javascript file includes into separate method calls, it works. But when called with the javascriptS tag, it breaks.

I think some of the CSS is broken also but let's sort out the JS first.

Please help ASAP.

Thanks,

Galen

1. 2 Posted by John Nunemaker on 27 Jan, 2011 09:52 PM

   

   Fixed timerworks. It seems it needed a ;. Will add this into the merging so it is handled properly long run.

   Now looking into the other gallery.

   Admin Functions

   • Edit
   • Split
   • Remove

2. 3 Posted by John Nunemaker on 27 Jan, 2011 09:56 PM

   

   Looking into it right now.

   Admin Functions

   • Edit
   • Split
   • Remove

3. 4 Posted by John Nunemaker on 27 Jan, 2011 10:04 PM

   

   I have fixed both of the sites.

   The issue on furneaux is that we cannot automatically merge google's ajax libs with libs in harmony as they are not on our server. You had:

   {{ 'http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js,jquery.fancybox1.3.1.pack' | javascripts }}
   

   But it should be:

   {{ 'jquery.1.4' | google_javascript }}
   {{ 'jquery.fancybox1.3.1.pack' | javascripts }}
   

   This was an edge case we were not prepared for. I think from now on we will document that javascripts filter should only be used with harmony javascript files. If you want to use remotes, we will have to recommend using the singular javascript filter to create the tag on the fly.

   Apologies for this causing issues. I have created an issue for the semi-colon problem and we will get that out soon.

   Are you sure you are having css issues? We had a few issues that we fixed promptly after deploying the css concatenation, but they should not be causing issues anymore. Please let me know which sites if any are and I will create test cases and resolve the issue quickly.

   Thanks so much for letting us know Galen.

   Admin Functions

   • Edit
   • Split
   • Remove

4. 5 Posted by Galen King on 28 Jan, 2011 01:48 AM

   

   Thanks John. Much appreciated.

   Admin Functions

   • Edit
   • Split
   • Remove

5. John Nunemaker closed this discussion on 30 Jan, 2011 02:21 AM.

Comments are currently closed for this discussion. You can start a new one.